Release/0.4.2 #11

Merged
Qrashi merged 6 commits from release/0.4.2 into main 2026-01-17 00:45:00 +01:00
Qrashi commented 2026-01-17 00:30:14 +01:00 (Migrated from github.com)

Fix animated messages going over multiple lines

  • Auto-truncate messages too long
  • Fix issue where multiline message would get only its last line replaced. Will now always print multiline message with stays_in_one_line = False
  • Add common mistakes section to cliasi_instance.rst
  • Update documentation with new auto-truncate behaviour
  • Add tests
Fix animated messages going over multiple lines * Auto-truncate messages too long * Fix issue where multiline message would get only its last line replaced. Will now always print multiline message with stays_in_one_line = False * Add common mistakes section to cliasi_instance.rst * Update documentation with new auto-truncate behaviour * Add tests
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2026-01-17 00:32:49 +01:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Pull request overview

This PR fixes issues with animated messages that span multiple lines by implementing auto-truncation and improving multiline message handling.

Changes:

  • Add auto-truncation for animated messages that exceed terminal width
  • Fix multiline message handling to always use force_multiline mode when messages contain newlines or exceed available space
  • Add documentation about the new truncation behavior and common instance creation mistakes
  • Add test coverage for the new truncation and multiline handling

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
tests/test_cliasi.py Adds three new tests for wrapped messages, explicit newlines, and message truncation behavior
src/cliasi/cliasi.py Implements force_multiline flag, message truncation logic in animations, fixes whitespace indentation, and updates return type annotations
docs/source/message_types.rst Adds notes about auto-truncation in animations and progress bars, fixes underline lengths
docs/source/cliasi_instance.rst Adds examples and common mistakes section about instance creation timing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

## Pull request overview This PR fixes issues with animated messages that span multiple lines by implementing auto-truncation and improving multiline message handling. **Changes:** - Add auto-truncation for animated messages that exceed terminal width - Fix multiline message handling to always use `force_multiline` mode when messages contain newlines or exceed available space - Add documentation about the new truncation behavior and common instance creation mistakes - Add test coverage for the new truncation and multiline handling ### Reviewed changes Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments. | File | Description | | ---- | ----------- | | tests/test_cliasi.py | Adds three new tests for wrapped messages, explicit newlines, and message truncation behavior | | src/cliasi/cliasi.py | Implements force_multiline flag, message truncation logic in animations, fixes whitespace indentation, and updates return type annotations | | docs/source/message_types.rst | Adds notes about auto-truncation in animations and progress bars, fixes underline lengths | | docs/source/cliasi_instance.rst | Adds examples and common mistakes section about instance creation timing | --- 💡 <a href="/IgnyteX-Labs/cliasi/new/main/.github/instructions?filename=*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2026-01-17 00:32:48 +01:00

Corrected spelling of 'databasee_module' to 'database_module'.

Corrected spelling of 'databasee_module' to 'database_module'.
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2026-01-17 00:32:48 +01:00

Corrected spelling of 'databasee_module' to 'database_module'.

Corrected spelling of 'databasee_module' to 'database_module'.
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2026-01-17 00:32:48 +01:00

The return type was changed from NonBlockingAnimationTask | None to NonBlockingAnimationTask, but the function can still return the result of __get_null_task() when verbosity check fails (line 1591). While __get_null_task() returns a NonBlockingProgressTask which is a subclass of NonBlockingAnimationTask, this change removes the explicit None from the return type. Verify this change is intentional and that the null task pattern is sufficient for all consumers of this API.

The return type was changed from `NonBlockingAnimationTask | None` to `NonBlockingAnimationTask`, but the function can still return the result of `__get_null_task()` when verbosity check fails (line 1591). While `__get_null_task()` returns a `NonBlockingProgressTask` which is a subclass of `NonBlockingAnimationTask`, this change removes the explicit `None` from the return type. Verify this change is intentional and that the null task pattern is sufficient for all consumers of this API.
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2026-01-17 00:32:49 +01:00

The return type was changed from NonBlockingAnimationTask | None to NonBlockingAnimationTask, but the function can still return the result of __get_null_task() when verbosity check fails (line 1647). While __get_null_task() returns a NonBlockingProgressTask which is a subclass of NonBlockingAnimationTask, this change removes the explicit None from the return type. Verify this change is intentional and that the null task pattern is sufficient for all consumers of this API.

The return type was changed from `NonBlockingAnimationTask | None` to `NonBlockingAnimationTask`, but the function can still return the result of `__get_null_task()` when verbosity check fails (line 1647). While `__get_null_task()` returns a `NonBlockingProgressTask` which is a subclass of `NonBlockingAnimationTask`, this change removes the explicit `None` from the return type. Verify this change is intentional and that the null task pattern is sufficient for all consumers of this API.
Sign in to join this conversation.
No description provided.